allow passing username and password through environment variables #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,8 +40,18 @@ def main(): | |||
| help='Connection port') | |||
| parser.add_argument('-u', '--user', | |||
| help='Connection username') | |||
| parser.add_argument('--user-environment-variable-name', | |||
There was a problem hiding this comment.
What is the advantage of having configurable environment variables for these two values instead of having a default one?
There was a problem hiding this comment.
Zen of Python line two, my friend. :-)
There was a problem hiding this comment.
If we were going to make it implicit, I'd probably do it by allowing any command line option to be overridden by setting $CASSANDRA_MIGRATE_{uppercased_option_name}. Do you think that would be preferable?
There was a problem hiding this comment.
I like that idea, but I wouldn't block this PR because of that. I think just implementing the ones that you're gonna need right now would be enough, but it's always up to you :)
Roguelazer
force-pushed
the
issue-12
branch
from
5132e9a
to
29409a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are kind of long and clunky arguments but at least they're unambiguous.