Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker as possible environment for development #43

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AdamStrojek
Copy link

I have created basic structure that helps in developing project using Docker. Some IDE allows to use Docker image as Python interpreter. This allow to start everyone start developing code in no time

@danielkza
Copy link
Contributor

Hi Adam, sorry for the delay on getting to this.

Overall I love the idea of setting up a Docker dev-env, but I have a few reservations over the approach.

a) Seeing a Dockerfile in the root of the repository creates the expectation that there is an image that you can use for actually running cassandra-migrate, not just developing it, and that is yet not the case.
b) It's much easier to develop by mounting the code folder instead of copying it and rebuilding the image every time. Since there's no .dockerignore file, it will also pull a local virtualenv if you have one and lots of extraneous files. docker-compose works better for that case, and will also allow you to easily spin up a Cassandra instance for testing.
c) I don't like having to maintain an author list. The git history does that job much better.

I understand if you don't have the time to work on all this; in that case, I'll get to it in the near future.

Thank you very much for your contribution either way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants