Fix unwind on SIGSEGV on aarch64 (due to small stack for signal) #64058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
robot-ch-test-poll3
added
the
pr-bugfix
|
This is an automated comment for commit 81a0c63 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
nickitat
approved these changes
May 17, 2024
|
Confirmed, works |
|
TSan MSan |
|
@azat let's rerun, I've added To pr description. |
Only SIGSEGV uses alternative stack (sigaltstack()), which is very
small, 16K, and for aarch64 it is likely not enough for unwinding
(likely due to lots of registers on this platform):
(gdb) bt
#0 libunwind::CFI_Parser<libunwind::LocalAddressSpace>::parseFDEInstructions (addressSpace=..., fdeInfo=..., cieInfo=..., upToPC=<optimized out>, arch=4, results=<optimized out>) at ./contrib/libunwind/src/DwarfParser.hpp:561
And this is:
554 case DW_CFA_remember_state: {
555 // Avoid operator new because that would be an upward dependency.
556 // Avoid malloc because it needs heap allocation.
557 PrologInfoStackEntry *entry =
558 (PrologInfoStackEntry *)_LIBUNWIND_REMEMBER_ALLOC(
559 sizeof(PrologInfoStackEntry));
560 if (entry != NULL) {
561 entry->next = rememberStack.entry;
^^^
562 entry->info = *results;
563 rememberStack.entry = entry;
564 } else {
565 return false;
566 }
567 _LIBUNWIND_TRACE_DWARF("DW_CFA_remember_state\n");
568 break;
569 }
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
fix-unwind-on-aarch64
branch
from
5ad98e8
to
81a0c63
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
robot-ch-test-poll
added
the
pr-synced-to-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix unwind on SIGSEGV on aarch64 (due to small stack for signal)
Only SIGSEGV uses alternative stack (sigaltstack()), which is very
small, 16K, and for aarch64 it is likely not enough for unwinding
(likely due to lots of registers on this platform):
And this is:
Fixes: #63855 (cc @maxknv)
Reverts: #63867
Supersedes: #63959 (cc @alesapin )
#job_style_check
#job_Integration_tests_aarch64
#job_Integration_tests_release