Fixed restricted users' usernames not being clickable #5405
Conversation
It's more of an "author" anyway then a regular mention
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -735,6 +738,26 @@ void MentionElement::addToContainer(MessageLayoutContainer &container, | |||
| TextElement::addToContainer(container, flags); | |||
| } | |||
|
|
|||
| MessageElement *MentionElement::setLink(const Link &link) | |||
| { | |||
| assert(false && "MentionElement::setLink should not be called. Pass " | |||
There was a problem hiding this comment.
warning: no header providing "assert" is directly included [misc-include-cleaner]
src/messages/MessageElement.cpp:15:
+ #include <cassert>
Can you please also check how irc user cards work after this change? I am unable to do it for most of today |
The author is unchanged, both open usercards of the name Mentions are unchanged, they don't open anything I don't have to merge this in right now, so I can let you give it a try as well |
|
|
| @@ -735,6 +738,26 @@ void MentionElement::addToContainer(MessageLayoutContainer &container, | |||
| TextElement::addToContainer(container, flags); | |||
| } | |||
|
|
|||
| MessageElement *MentionElement::setLink(const Link &link) | |||
| { | |||
| assert(false && "MentionElement::setLink should not be called. Pass " | |||
There was a problem hiding this comment.
warning: no header providing "assert" is directly included [misc-include-cleaner]
src/messages/MessageElement.cpp:15:
+ #include <cassert>
also made the linking be automatic from now on, ensuring we don't make the same mistake again with MentionElements