chore: remove old Qt code, update docs and FreeBSD runner #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
May 14, 2024
BUILDING_ON_FREEBSD.md
Outdated
| 1. Generate build files. To enable Lua plugins in your build add `-DCHATTERINO_PLUGINS=ON` to this command. | ||
| ```sh | ||
| cmake .. | ||
| cmake -B build |
There was a problem hiding this comment.
Add the -DBUILD_WITH_QT6=ON flag
Comment on lines
-37
to
+36
| - `Qt 5 Compatibility Module` | ||
| - `MSVC 2019 64-bit` (or `MSVC 2022 64-bit` from Qt 6.8 onwards) |
There was a problem hiding this comment.
What made us not need the compat module on Windows anymore?
| @@ -66,9 +65,9 @@ These dependencies are only required if you are not using a package manager | |||
| - Visit the downloads list on [SourceForge](https://sourceforge.net/projects/boost/files/boost-binaries/). | |||
| - Select the latest version from the list. | |||
| - Download the `.exe` file appropriate to your Visual Studio installation version and system bitness (choose `-64` for 64-bit systems). | |||
| Visual Studio versions map as follows: `14.3` in the filename corresponds to MSVC 2022,`14.2` to 2019, `14.1` to 2017, `14.0` to 2015. _Anything prior to Visual Studio 2015 is unsupported. Please upgrade should you have an older installation._ | |||
| Visual Studio versions map as follows: `14.3` in the filename corresponds to MSVC 2022. _Anything prior to Visual Studio 2022 is unsupported. Please upgrade should you have an older installation._ | |||
There was a problem hiding this comment.
Keep the 2019 version, I'm happy to try to support if should someone be stuck with it
pajlada
reviewed
May 15, 2024
| @@ -1,5 +1,5 @@ | |||
| freebsd_instance: | |||
| image: freebsd-14-0-release-amd64 | |||
| image_family: freebsd-14-0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this PR removes code disabled in builds with Qt 5.15.2 or later, updates docs (some minor stuff) and updates the FreeBSD runner to 14.0.