Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change minimal near plane calculation #2002

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Change minimal near plane calculation #2002

wants to merge 2 commits into from

Conversation

375gnu
Copy link
Member

@375gnu 375gnu commented Dec 5, 2023 •
edited

this fixes some existing issues but cause other ones, so i'm unsure if we should merge this.

if previously we have part of planet cut when we're very close to a planet surface, now at certain angles we have garbage on the screen.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@375gnu 375gnu marked this pull request as draft December 20, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajtribick ajtribick ajtribick approved these changes

Assignees
No one assigned
Labels
not ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@375gnu @ajtribick