Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use suggestions if object searched is not found #1329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't use suggestions if object searched is not found #1329

wants to merge 1 commit into from

Conversation

375gnu
Copy link
Member

@375gnu 375gnu commented Jan 20, 2022

Closes: #604

It seems not all users are happy with this feature so let's hide it behind #ifdef.

@375gnu 375gnu requested a review from a team January 20, 2022 16:47
@SevenSpheres
Copy link
Contributor

SevenSpheres commented Jan 20, 2022 •
edited

Since opening the issue I've found that this is sometimes annoying but sometimes useful, and the issue with Eps Ind B was already fixed. Maybe it should be a configurable option.

@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

ajtribick
ajtribick approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@ajtribick ajtribick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as it does what it sets out to do. I think I actually prefer the autocomplete behaviour, although it would probably be more user-friendly to have the first item highlighted to imply this will be selected.

@375gnu 375gnu force-pushed the master branch 2 times, most recently from 690ab56 to 2f8f3b0 Compare May 15, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajtribick ajtribick ajtribick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.7.0] Autocompletion in search
3 participants
@375gnu @SevenSpheres @ajtribick