Allow use of null values in enums on active record 5 #833
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtagle2
force-pushed
the
develop
branch
3 times, most recently
from
a3f9f3e
to
ff43b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you have enum with null values, it fails the validation on CanCanCan because it casts the values received on the condition to strings, but the values that comes from the subject are not casted. This PR tries to manage that case, because nil in ruby is casted to the empty string, so if you have a condition like
can action, model, enum_attribute: [null, :value], on the accessible_by it works correctly for rows with null value, but when doing thecan?on a specific record, it fails if it has null value.