feat: add a http interface to plugins #814
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is only a first draft. @sbrunato wdyt ? |
Test Results 2 files - 2 2 suites - 2 27s ⏱️ - 5m 3s For more details on these errors, see this check. Results for commit 2b8f8c3. ± Comparison against base commit d0869f9. This pull request removes 391 and adds 22 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Code Coverage (Ubuntu)
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2b8f8c3 |
|
Code Coverage (Windows)
Minimum allowed coverage is Generated by 🐒 cobertura-action against ceaf822 |
this interface allow to transparently handle requests authentication within the Authentication plugin to lift the burden on search and download plugins. Also it centralise authentication management and allow for more complexe authentication mechanisms like refresh when required, etc.
alambare-csgroup
force-pushed
the
add-http-interface
branch
from
ceaf822
to
2b8f8c3
Compare
- add ftp requests native support for http requests using format ftp:// - HttpResponse is now requests.Response - simplify auth http requests handling - sever aws download from aws auth - remove calls from requests to use HttpRequest instead - add some type hint
alambare-csgroup
force-pushed
the
add-http-interface
branch
from
e947d0e
to
7289d85
Compare
alambare-csgroup
force-pushed
the
add-http-interface
branch
from
7289d85
to
a77ac0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this interface allow to transparently handle requests authentication within the Authentication plugin to lift the burden on search and download plugins.
Also it centralise authentication management and allow for more complexe authentication mechanisms like refresh when required, etc.
Your checklist for this pull request
Please review the guidelines for contributing to this repository.
Description
Please describe your pull request.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Thank you!