refactor(angular): refactored angular related imports generation #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
samijaber
approved these changes
Sep 23, 2022
| * @param json The component to add the import to | ||
| * @param theImport The import to add | ||
| */ | ||
| export function addImportToMitosisComponent( |
There was a problem hiding this comment.
We don't have this yet. Thanks for putting it together!
There was a problem hiding this comment.
Aand I need to update snapshots here as well
g-cheishvili
force-pushed
the
refactor/angular_related_imports
branch
from
95984d8
to
9c833c4
Compare
|
@samijaber fixed everything. Take a look |
|
@g-cheishvili I believe this is still pending updating snapshots? |
|
@g-cheishvili any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
populatedWithAngularImportsand moved adding Angular related imports to be BEFOREjson.postcall.MitosisComponent. I do not know if something like it existed, could not find it, so added it. if there is any, please refer me to it.Reasoning
I added these because otherwise in
json.postyou can not see which imports are gonna end up in file completely. Also, output code's structure is now better because it follows a widely accepted pattern: