Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle text input in react native generator #1435

Merged
merged 10 commits into from
May 17, 2024

Conversation

Othman2001
Copy link
Contributor

Description

adding text input in the react native generator, react native text input handling is missed, we should convert input tag from react to TextInput and add styles, onChange and so on

this is a fix for this issue:
#1390

@Othman2001 Othman2001 requested a review from samijaber as a code owner May 8, 2024 21:55
Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 9315836

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Othman2001 Othman2001 requested a review from samijaber May 15, 2024 09:13
Copy link

nx-cloud bot commented May 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9315836. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@Othman2001 Othman2001 requested a review from samijaber May 16, 2024 14:34
Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@samijaber samijaber merged commit 3d8b354 into BuilderIO:main May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants