-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce googleapi calls #13704
Merged
Merged
Reduce googleapi calls #13704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
force-pushed
the
BUDI-8248/reduce-googleapi-calls
branch
from
May 17, 2024 10:07
d359a7d
to
a780a29
Compare
adrinr
commented
May 17, 2024
@@ -79,7 +79,7 @@ | |||
"dotenv": "8.2.0", | |||
"form-data": "4.0.0", | |||
"global-agent": "3.0.0", | |||
"google-spreadsheet": "4.1.2", | |||
"google-spreadsheet": "npm:@budibase/google-spreadsheet@4.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is temporal, I use a package override. This will help us as we will not need to update code references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice - good way to solve this!
adrinr
requested review from
samwho and
mike12345567
and removed request for
a team
May 17, 2024 10:14
mike12345567
approved these changes
May 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Google api calls are pretty slow, and due the current flow we can have multiple requests per read. The current logic runs as it follows:
This contains redundant calls. Storing the client references in the context, we are performing much quicker calls. Results as described below. Both scenarios ran with running a search with pagination results.
Before, avg. of
5.17s
:After, avg. of
2.05s
:Addresses
Launchcontrol
Improving google sheets read performance
Feature branch env
Feature Branch Link