Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jfrog artifactory backend server for bob artifacts #445

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

jfrog artifactory backend server for bob artifacts #445

wants to merge 3 commits into from

Conversation

mahaase
Copy link
Contributor

@mahaase mahaase commented Nov 1, 2021

rhubert and others added 3 commits May 4, 2019 17:35
@rhubert
archive: added JFrog Artifactory backend
6a46220 
The JFrog artifactory backend uses the dohq-artifcatory python lib and supports the
authentication methods (username+password, API-Key, global configuration file) provided
by this library.
@rhubert
artifactory-archive: add properties to artifcats
1e812c2 
Artifactory supports properties for artifcats. Added the properties key for archive spec
to provide archive properties. The properties are substitued whit the packageStep / metaEnv
of the package.

archive:
  backend: "artifactory"
  url: "http://localhost:8081/artifactory/example-repo-local"

  properties:
     FOO: "42"
     BAR: "13"
     TEST: "${TEST:-NotSet}"
@mahaase
Merged branch 'artifactory' of https://github.com/rhubert/bob.git int…
25a69ec 
…o current master

resolved some conflicts and removed the replacing of slashes with underlines in upload/download url/tree
@rhubert
Copy link
Contributor

rhubert commented Nov 2, 2021

There are some open issues in #240. Do you plan to solve them? Otherwise it might be better to reopen #240 and resume working on this?
How do you delete artifacts from artifactory? Are you using bob archive on the server?

@mahaase
Copy link
Contributor Author

mahaase commented Nov 2, 2021

I can also open a MR to your branch, so u don't have to sync with master again.
Then we can reopen the #240.

How do you delete artifacts from artifactory? Are you using bob archive on the server?

Currently we do not delete artifacts at all. But yeah, I have no idea, how it could be possible to clean up the artifactory.
I don't know how the artifactory is managed in background and if bob archive would work.
Good point, we should check this here.

@rhubert
Copy link
Contributor

rhubert commented Nov 2, 2021

I can just use your branch - this won't make a difference ;) I'm just asking because ATM I'm using http upload to artifatory (no need for additional properties) and this works without any problems. I don't have a good use case for additional artifactory integration - which properties are needed,... ? I'd need some input from your side.

 I don't know how the artifactory is managed in background and if bob archive would work.

I've a bob archive with support for artifactory cleanup, but this is currently only in a 'works-somehow' state...

@mahaase
Copy link
Contributor Author

mahaase commented Nov 2, 2021

the option to get additional properties would be nice. e.g. for images that will be released to customer. we could adapt the recipe like this, that a user of artifactory get all necessary information: versions, dependencies, variants, ....

I've a bob archive with support for artifactory cleanup, but this is currently only in a 'works-somehow' state...

sounds cool, for a full bob-artifactory support, this is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mahaase @rhubert