Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nexus_sdk from nexus store when uploading files and add x-nxs-file-content-length to header #403

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

crisely09
Copy link
Contributor

@crisely09 crisely09 commented May 13, 2024

Changes:

  • Replace the use of nexus_sdk with requests.post call
  • Add x-nxs-file-content-length parameter to headers

@crisely09 crisely09 requested review from ssssarah and MFSY May 13, 2024 10:51
@crisely09 crisely09 self-assigned this May 14, 2024
@crisely09 crisely09 requested a review from imsdu May 15, 2024 09:24
@crisely09 crisely09 changed the title Remove nexus_sdk from nexus store when uploading files and add Content-Length to header Remove nexus_sdk from nexus store when uploading files and add x-nxs-file-content-length to header May 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 75.65%. Comparing base (be27bb6) to head (bc53dac).

Files Patch % Lines
kgforge/specializations/stores/bluebrain_nexus.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   75.69%   75.65%   -0.05%     
==========================================
  Files         103      103              
  Lines        6753     6761       +8     
==========================================
+ Hits         5112     5115       +3     
- Misses       1641     1646       +5     
Flag Coverage Δ
unittests 75.65% <36.36%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants