Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search when looking for a literal to be unequal to a value #397

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ssssarah
Copy link
Contributor

When specifying that a value which is a literal that should be unequal to a value, it would check that it is equal to it. This fixes that

@ssssarah ssssarah requested review from crisely09 and MFSY April 23, 2024 07:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.69%. Comparing base (28cddab) to head (7fed745).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   75.70%   75.69%   -0.02%     
==========================================
  Files         103      103              
  Lines        6751     6748       -3     
==========================================
- Hits         5111     5108       -3     
  Misses       1640     1640              
Flag Coverage Δ
unittests 75.69% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crisely09
crisely09 previously approved these changes Apr 25, 2024
Copy link
Contributor

@crisely09 crisely09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@crisely09 crisely09 self-requested a review April 25, 2024 13:43
@crisely09 crisely09 dismissed their stale review April 25, 2024 13:43

test are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants