Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further restrict IsolatedProcess by setting multiprocessing start method #181

Merged
merged 3 commits into from May 8, 2024

Conversation

anilbey
Copy link
Collaborator

@anilbey anilbey commented May 8, 2024

This is to ensure all workers of IsolatedProcesss are going to be started via the fork mode, not the spawn mode.
Note: fork mode passes the parameters from the parent to child. Spawn does not (it leads to unexpected results when used with NEURON).
Source: neuronsimulator/nrn#2842 (comment)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (fcf8ad0) to head (fe3b446).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   91.23%   91.24%           
=======================================
  Files          95       95           
  Lines        5626     5628    +2     
=======================================
+ Hits         5133     5135    +2     
  Misses        493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilbey anilbey merged commit 62947a9 into main May 8, 2024
10 checks passed
@anilbey anilbey deleted the isolated-processes branch May 8, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants