Remove ugly CMake hack #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovazquezblanco
force-pushed
the
dev/remove_hack
branch
from
462541a
to
595dec5
Compare
antoniovazquezblanco
force-pushed
the
dev/remove_hack
branch
from
595dec5
to
b3af233
Compare
Alternatively add a relative path __FILE__ macro definition module
antoniovazquezblanco
force-pushed
the
dev/remove_hack
branch
from
b3af233
to
a3b81d7
Compare
|
This is gold. Old hack removed but alternatively implemented with proper CMake commands. |
|
Amazing work, dude! Merging right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, it had to go sooner or later...
See: https://discourse.cmake.org/t/cmake-file-name-in-a-portable-way/6918
The hack was not portable. That means that only worked with Makefiles as the CMake backend. That means that Ninja backend cannot be used. That means that MSYS will probably won't accept a PR with this package (msys2/MINGW-packages#10543 (comment)). Therefore the hack is ugly...
I don't like embedding full paths in binaries for many reasons. I've tryed to avoid that by using the new FILE_NAME macro available in GCC 12 and newer. If not available, the full path is used...