Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CMakeLists #42

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Improve CMakeLists #42

merged 1 commit into from
Apr 12, 2023

Conversation

antoniovazquezblanco
Copy link
Contributor

  • Move include_directories and link_directories to dependency checking section
  • Move all configuration options to a section
  • Remove unneded build type configuration flags
  • Specialize release build flags for the GNU compiler
  • Simplify PKGVERSION definition
  • Reorder module imports for best results

@antoniovazquezblanco
Copy link
Contributor Author

Related issue:
#37

@antoniovazquezblanco
Improve CMakeLists
1e7280b 
- Move include_directories and link_directories to dependency checking
section
- Move all configuration options to a section
- Remove unneded build type configuration flags
- Specialize release build flags for the GNU compiler
- Simplify PKGVERSION definition
- Reorder module imports for best results
@BatchDrake
Copy link
Owner

LGTM

@BatchDrake BatchDrake merged commit ee69a36 into BatchDrake:develop Apr 12, 2023
5 checks passed
@antoniovazquezblanco antoniovazquezblanco deleted the dev/cmake branch April 12, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antoniovazquezblanco @BatchDrake