Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve git aliases #2176

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve git aliases #2176

wants to merge 3 commits into from

Conversation

royatt
Copy link

@royatt royatt commented Dec 2, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@royatt royatt marked this pull request as draft December 2, 2022 20:18
@royatt royatt changed the title Draft: Improve git aliases Improve git aliases Dec 2, 2022
@royatt
Copy link
Author

royatt commented Dec 3, 2022

@NoahGorny

cornfeedhobo
cornfeedhobo reviewed Dec 3, 2022
View reviewed changes
aliases/available/git.aliases.bash Outdated
else
echo master
fi
git symbolic-ref refs/remotes/origin/HEAD | sed 's@^refs/remotes/origin/@@'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use a bash substitution instead of farming out to sed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is very much possible, good idea, changed it in the newest commit.
think I should squash it down later with the original commit if it looks good

@royatt royatt force-pushed the improve-git-aliases branch 2 times, most recently from d9c339c to 949309d Compare December 5, 2022 20:19
@royatt royatt marked this pull request as ready for review December 23, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cornfeedhobo cornfeedhobo cornfeedhobo left review comments

@NoahGorny NoahGorny NoahGorny left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@royatt @cornfeedhobo @NoahGorny