web: add option for making user name unique #5620
Conversation
We currently allow different accounts to have the same user name.
Hence in places where we need to identify users
(sending PMs, blocking users) we have to use numeric IDs,
which means that we have to display them in various places.
This is ugly; I'm not sure why I thought it was a good idea.
Anyway. Add a project.inc option UNIQUE_USER_NAME. If set:
- it won't let you create an account with a dup name,
of change your name to a dup
- it doesn't show user IDs anywhere
- in places where you specify users, you use names
This is now the default for new projects.
Existing projects - which have lots of duplicate names -
can't use it unless they de-dup their names somehow
(and this might anger users).
Also some minor code cleanup. sprintf() is our friend.
make show_user() (for user search results) overrideable by project. modernize default show_user()
define SHOW_USER_FILENAME to specify your user page
…not contain' stuff
change SHOW_USER_FILENAME to SHOW_USER_PAGE
(and define it in util.inc if not already defined)
friend links: don't use a table
Don't show it if NO_COMPUTING.
|
So when there's new projects on the horizon and others are faster than me, it can easily happen that at project x I'm walli, at project y woofy and at z I'll have to become Chewbacca?! Sorry, but that's exactly what I find ugly. With this new default setting, you now have even fewer options to recognize me across different projects than with the old standard behaviour. And if I wanted to have different usernames, that was already possible before, now I'm more or less forced to that situation (as far as new project admins are unaware of this setting)... I don't like it and I'm in favour of not merging this pull request or at least please don't set this behaviour as the new default. |
|
Currently, when you specify a user (e.g. to send a PM to several users) you enter their user name. So everywhere we show a user name we need to show their database ID too, like 'John (33)'. This is a mess. There should be one and only one way to identify a user. Having the same name across projects is fine, |
We currently allow different accounts to have the same user name.
Hence in places where we need to identify users
(sending PMs, blocking users) we have to use numeric IDs,
which means that we have to display them in various places.
This is ugly; I'm not sure why I thought it was a good idea.
Anyway. Add a project.inc option UNIQUE_USER_NAME. If set:
of change your name to a dup
This is now the default for new projects.
Existing projects - which have lots of duplicate names -
can't use it unless they de-dup their names somehow
(and this might anger users).
Also some minor code cleanup. sprintf() is our friend.