adding a method to patch linux idle check with required libraries. #5354

0x0OZ · 2023-09-09T13:15:40Z

Fixes # Linux checking being idle, A fix for #1187

Description of the Change

added a method that does the check without really replacing it with the existing poor check to be reviewed and added by a C++ developer.
Alternate Designs

Release Notes

Fixing linux idle check by listening for input events in /dev/input/*.

If this change is not user-facing or notable enough to be included in release notes you may use the string "N/A" here. -->
To this run correctly, the user running the client has to have read and execute permissions on /dev/input/* files, this can be done using setfacl

AenBleidd · 2023-09-09T13:35:48Z

client/hostinfo_unix.cpp

+    }
+
+    // Main loop to monitor input events
+    while (true) {


This will lead to the dead lock of the BOINC Client. Instead, this functions should be called outside and return result as fast as possible.
Please be sure to test your changes before making a PR.

I want to have an opinion before making any further changes, This code could be added separately, runs in the background while the client is running, and writes the time of being idle to a tmp file, which can be read inside the client at any time.
But I am not sure if you agree with this idea to be added to the code,

Also, as I mentioned it will need permissions to read and execute /dev/input which regular users don't have by default.
So separating it could be a better approach to give the file its own permissions because having such permissions to a whole user is a security risk -keylogging is an example of what could go wrong-.

Don't get me wrong, but this is a not a good approach: you did some implementation, but you haven't tested it. What is more important - we can't test it as well, because we can't just use your code and run any test, because obviously everything will just hang in an infinite loop.
If you have an idea but don't know how to implement it properly - it's better to describe your idea in detail and ask for advice.

You are right.
I've removed the infinite loop and fixed the stupid logic.
But I also haven't removed any existing code.

I'll push the updates to the pull (when I figure out how).

While on this branch:
git add . && git commit && git push

AenBleidd · 2023-09-09T13:36:42Z

client/hostinfo_unix.cpp

+    // Use glob to enumerate input devices in /dev/input/
+    glob_t globbuf;
+    if (glob("/dev/input/event*", GLOB_NOSORT, nullptr, &globbuf) != 0) {
+        std::cerr << "Failed to enumerate input devices. " << std::endl;


msg_printfshould be used instead of the direct std:: calls.

Please fix this comment as well

It should be all good now.

0x0OZ · 2023-09-10T11:14:35Z

It seems I added the includes in the wrong place as android is still trying to include them

https://github.com/BOINC/boinc/pull/5354/files#diff-b710fcc072350b8bbb1bc13eb394da5cdbc0b0dfab019a93890ec10eadb41b86R180-R188

AenBleidd · 2023-09-10T12:05:56Z

@0x0OZ, Client is failed to build as well, you need to include 'libevdev' here to install it on CI:

boinc/.github/workflows/linux.yml

Line 53 in eac3e3a

    
                     sudo apt-get install -y libftgl-dev freeglut3-dev libcurl4-openssl-dev libxmu-dev libxi-dev libfcgi-dev libxss-dev libnotify-dev libxcb-util0-dev libgtk-3-dev libsecret-1-dev libgcrypt20-dev libsystemd-dev libwebkit2gtk-4.0-dev p7zip-full libxxf86vm-dev ocl-icd-opencl-dev zip

0x0OZ · 2023-09-10T15:42:52Z

@AenBleidd client still fails,
I need to add -levdev flag to the MakeFile, but I am not sure how it's being built

…nfo_unix

AenBleidd · 2023-09-10T17:57:00Z

@AenBleidd client still fails,

I need to add -levdev flag to the MakeFile, but I am not sure how it's being built

You need to add this linker flags somewhere to this file: https://github.com/BOINC/boinc/blob/master/configure.ac

…efficient and optimized.

0x0OZ · 2023-09-10T18:58:55Z

@AenBleidd client still fails,
I need to add -levdev flag to the MakeFile, but I am not sure how it's being built

You need to add this linker flags somewhere to this file: https://github.com/BOINC/boinc/blob/master/configure.ac

Like I understand a single word 😅, I'll try to.

0x0OZ · 2023-09-10T22:29:40Z

I made it worse with the last change to configure.ac...
I will try to find out how this thing work.

…r source code checker

0x0OZ · 2023-09-11T11:59:21Z

@AenBleidd Linux client now builds successfully,
But other clients still fail because they try to import libevdev when it should be included only in Linux env.

0x0OZ · 2023-09-18T20:25:20Z

Hey @AenBleidd,
I want to remind you of this pull,
is there anything I need to do from my side?

AenBleidd · 2023-09-18T20:29:52Z

@0x0OZ, it would be nice to fix this build for all other OSs...

…clude only for linux

0x0OZ · 2023-09-19T18:00:05Z

Snap fails because libevdev is not being installed for it, it's only installed using apt, android fails because it tries to add the linker -levdev.
I thought adding the weird condition I added should fix it but it didn't, for snap I couldn't yet figure out where the package installation should be added.

0x0OZ · 2023-09-20T06:14:14Z

@0x0OZ, it would be nice to fix this build for all other OSs...

That's done, everything builds successfully now.

codecov · 2023-09-20T07:55:17Z

Codecov Report

Merging #5354 (ffc5f0d) into master (eac3e3a) will decrease coverage by 0.01%.
Report is 16 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5354      +/-   ##
============================================
- Coverage     10.87%   10.87%   -0.01%     
  Complexity     1068     1068              
============================================
  Files           279      279              
  Lines         36059    36061       +2     
  Branches       8335     8335              
============================================
  Hits           3920     3920              
- Misses        31745    31747       +2     
  Partials        394      394

see 3 files with indirect coverage changes

0x0OZ · 2023-09-20T07:57:53Z

Snap failed, I thought it did not as at first it was skipped and didn't give an error.

0x0OZ · 2023-09-21T12:13:49Z

@AenBleidd All success but snap, and I know what's wrong but I don't know what could be done because I can't reproduce the error and it's done in a container...
It seems_ that snap doesn't go over the libs path /usr/lib/x86_64-linux-gnu/, because apt installs the missing lib there.
but I don't know what causes this.
I installed an Ubuntu VM and tried Ubnutu container inside that VM, Both recognized libevdev.so.2.

0x0OZ · 2023-09-28T20:31:25Z

I now have more time to work on this, Apart from the dead end for snap that I couldn't reproduce the bug and find a solution but it seems a docker thing? I have seen some issues that the libs installed during init weren't being recognized...
Also it doesn't detect ssh connection and it requires some privileges to access /dev/input/event* files.
because of this I think it would be better to make a stand-alone tool for an idle timer for every linux system.

This would be a better approach because of the permissions issue.

AenBleidd · 2023-09-28T20:37:40Z

because of this I think it would be better to make a stand-alone tool for an idle timer for every linux system.

And that is why we have this idea: #5226.

Since you're already have some experience with that, maybe you could work on this tool?
IT would be also nice, if before starting a coding you could do an investigation first and present your solution in the ticket I just mentioned and afterwards start doing coding?

0x0OZ · 2023-09-28T20:46:23Z

because of this I think it would be better to make a stand-alone tool for an idle timer for every linux system.

And that is why we have this idea: #5226.

Since you're already have some experience with that, maybe you could work on this tool? IT would be also nice, if before starting a coding you could do an investigation first and present your solution in the ticket I just mentioned and afterwards start doing coding?

Yes, I was thinking of doing that myself, I saw this ticket which gave me some insight.
After doing enough investigation I will share what I will build there which should solve the problem in all mentioned cases and be easily adaptable.

AenBleidd · 2023-09-28T20:47:51Z

@0x0OZ, nice! Thank you very much! In case you have any questions - feel free to reach out to me here or in BOINC Discord: https://discord.gg/wPRafUq

AenBleidd requested changes Sep 9, 2023

View reviewed changes

AenBleidd added C: Client - Linux P: Major T: Enhancement PR: Fix required labels Sep 9, 2023

AenBleidd added this to the Client/Manager 7.26.0 milestone Sep 9, 2023

removing the inf loop, and changing the idle check logic.

df64010

0x0OZ force-pushed the linux-idle-patch branch from 1a1fc6c to df64010 Compare September 9, 2023 17:25

using msg_printf instead of the direct std:: calls

59b9e9b

AenBleidd self-requested a review September 10, 2023 10:30

AenBleidd added PR: Review required and removed PR: Fix required labels Sep 10, 2023

0x0OZ added 3 commits September 10, 2023 15:13

adding libevdev-dev to github client packages to be installed

3b3d4e9

fixing libedev includes

00988e0

remove unsed include libevdev-uinput

f49eb5f

running trailing_whitespaces_check.py to fix trailing spaces on hosti…

25c17a7

…nfo_unix

modifying the logic for checking IDLE time to make it more accurate, …

7055499

…efficient and optimized.

adding levdev linker to

533ee08

0x0OZ added 2 commits September 11, 2023 13:33

trying to fix configure.ac after adding -levdev linker

336d97d

runnint trailing_whitespaces_check.py again to fix trailing spaces fo…

0a228c0

…r source code checker

trying to fix build for all OSs...

1108490

trying to fix build for all OSs by adding the levdev linker and an in…

a5284cf

…clude only for linux

0x0OZ added 2 commits September 20, 2023 08:33

trying to fix build for android devices

375ce7a

trying to fix build for snap

ebc18d8

trying to fix build for snap

33b250a

trying to fix build for snap by adding another path to LID_PATH...

ffc5f0d

AenBleidd marked this pull request as draft October 7, 2023 09:51

AenBleidd modified the milestones: Client/Manager 8.0.0, Client/Manager 8.1.0 Mar 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding a method to patch linux idle check with required libraries. #5354

adding a method to patch linux idle check with required libraries. #5354

0x0OZ commented Sep 9, 2023 •

edited

AenBleidd Sep 9, 2023

0x0OZ Sep 9, 2023 •

edited

AenBleidd Sep 9, 2023

0x0OZ Sep 9, 2023

AenBleidd Sep 9, 2023

AenBleidd Sep 9, 2023

AenBleidd Sep 9, 2023

0x0OZ Sep 9, 2023

0x0OZ commented Sep 10, 2023

AenBleidd commented Sep 10, 2023

0x0OZ commented Sep 10, 2023

AenBleidd commented Sep 10, 2023

0x0OZ commented Sep 10, 2023

0x0OZ commented Sep 10, 2023

0x0OZ commented Sep 11, 2023 •

edited

0x0OZ commented Sep 18, 2023

AenBleidd commented Sep 18, 2023

0x0OZ commented Sep 19, 2023

0x0OZ commented Sep 20, 2023 •

edited

codecov bot commented Sep 20, 2023 •

edited

0x0OZ commented Sep 20, 2023

0x0OZ commented Sep 21, 2023

0x0OZ commented Sep 28, 2023

AenBleidd commented Sep 28, 2023

0x0OZ commented Sep 28, 2023

AenBleidd commented Sep 28, 2023

adding a method to patch linux idle check with required libraries. #5354

Are you sure you want to change the base?

adding a method to patch linux idle check with required libraries. #5354

Conversation

0x0OZ commented Sep 9, 2023 • edited

AenBleidd Sep 9, 2023

Choose a reason for hiding this comment

0x0OZ Sep 9, 2023 • edited

Choose a reason for hiding this comment

AenBleidd Sep 9, 2023

Choose a reason for hiding this comment

0x0OZ Sep 9, 2023

Choose a reason for hiding this comment

AenBleidd Sep 9, 2023

Choose a reason for hiding this comment

AenBleidd Sep 9, 2023

Choose a reason for hiding this comment

AenBleidd Sep 9, 2023

Choose a reason for hiding this comment

0x0OZ Sep 9, 2023

Choose a reason for hiding this comment

0x0OZ commented Sep 10, 2023

AenBleidd commented Sep 10, 2023

0x0OZ commented Sep 10, 2023

AenBleidd commented Sep 10, 2023

0x0OZ commented Sep 10, 2023

0x0OZ commented Sep 10, 2023

0x0OZ commented Sep 11, 2023 • edited

0x0OZ commented Sep 18, 2023

AenBleidd commented Sep 18, 2023

0x0OZ commented Sep 19, 2023

0x0OZ commented Sep 20, 2023 • edited

codecov bot commented Sep 20, 2023 • edited

Codecov Report

0x0OZ commented Sep 20, 2023

0x0OZ commented Sep 21, 2023

0x0OZ commented Sep 28, 2023

AenBleidd commented Sep 28, 2023

0x0OZ commented Sep 28, 2023

AenBleidd commented Sep 28, 2023

0x0OZ commented Sep 9, 2023 •

edited

0x0OZ Sep 9, 2023 •

edited

0x0OZ commented Sep 11, 2023 •

edited

0x0OZ commented Sep 20, 2023 •

edited

codecov bot commented Sep 20, 2023 •

edited