[WIP] add server version to version.h

[davidpanderson]

... and have scheduler report server version, not client version

[lfield]

The build fails as version.h is created from version.h.in so the changes made to version.h in this pull requests are wiped. Note that we also have generate_svn_version.sh and svn_version.h. If we are not going to use this method to automatically get the version, we should delete these files so there is no confusion.

[davidpanderson]

OK, so we need to rename BOINC_VERSION to CLIENT_VERSION everywhere, and add a SERVER_VERSION to configure.ac. I'll leave it to someone else to do this.

May as well keep svn_version.h; that provides higher resolution info.

[brevilo]

Doesn't this mean that this PR should either be closed or at least be tagged as [WIP]?

[SETIguy]

Please use BOINC_CLIENT_VERSION and BOINC_SERVER_VERSION. Collision are less likely to happen that way.

…

On Wed, Feb 5, 2020 at 12:30 PM David Anderson ***@***.***> wrote: OK, so we need to rename BOINC_VERSION to CLIENT_VERSION everywhere, and add a SERVER_VERSION to configure.ac. I'll leave it to someone else to do this. May as well keep svn_version.h; that provides higher resolution info. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3448?email_source=notifications&email_token=ACS5ZMVY7SGMRU3AM7XVVDLRBMOX7A5CNFSM4KP624AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4332Y#issuecomment-582598123>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACS5ZMQABS66IQVZQ4A7VALRBMOX7ANCNFSM4KP624AA> .

-- Eric Korpela korpela@ssl.berkeley.edu AST:7731^29u18e3

[mcandre]

CI build logs appear to show a compilation error:

sched_types.cpp: In member function ‘int SCHEDULER_REPLY::write(FILE*, SCHEDULER_REQUEST&)’:

sched_types.cpp:770:9: error: ‘SERVER_MAJOR_VERSION’ was not declared in this scope

         SERVER_MAJOR_VERSION*100+SERVER_MINOR_VERSION

         ^

sched_types.cpp:770:34: error: ‘SERVER_MINOR_VERSION’ was not declared in this scope

         SERVER_MAJOR_VERSION*100+SERVER_MINOR_VERSION

                                  ^

make[2]: *** [sched_types.o] Error 1

make[2]: Leaving directory `/home/travis/build/BOINC/boinc/sched'

make[1]: *** [all-recursive] Error 1

make[1]: Leaving directory `/home/travis/build/BOINC/boinc'

make: *** [all] Error 2

The command "if [[ "${BOINC_TYPE}" == "server" ]]; then ( ./configure --disable-client --disable-manager && make ) fi" exited with 2.

[AenBleidd]

This PR is not ready to be merged because the whole idea should be revisited, please take a look at the conversation above

[AenBleidd]

@lfield, since you're currently working on new server release, could you please take a look at this PR again and either close it if it's not needed anymore or provide more correct implementation of it?