[DBUS] Don't break when reading settings from org.freedesktop.portalSettings v1 #15654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
Shouldn't this be fixed in Tmds.DBus.Protocol then? |
|
Closing this PR, as dbus upgrade was reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15568 made an attempt to correctly handle int32-in-variant-in-another-variant value (
[Variant: [Variant(uint): 2]]in qdbus notation), however the current version of Tmds.DBus.Protocol simply reads it as a single VariantValue with int32 type (tmds/Tmds.DBus#282).The PR removes GetItem call that wasn't intended to be used for unwrapping variants and adds a type check later just in case.
Verified with Plasma 5.27.
@affederaffe