Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] WindowDecorations related integration tests #15561

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[Windows] WindowDecorations related integration tests #15561

wants to merge 7 commits into from

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Apr 30, 2024 •
edited

What does the pull request do?

  1. Enabled avalonia name source generator in integration tests project.
  2. Implements basic TitleBarAutomationNode.
  3. Creates some basic tests for WindowDecorations:
  • Toggling window decorations shouldn't change window size. (disabled, as it's broken right now)
  • Client-side chrome title bar height tests.
  • Server-side chrome title bar height tests.
  • Client-side chrome title bar height tests for a new window. This test is failing if Win32 - Fix EntendClient hints not being applied window show #15552 is reverted.

No macOS tests for now. Maybe in another PR Done.

What is the current behavior?

No tests. Only manual, only hardcore.

What is the updated/expected behavior with this PR?

I can sleep better. A little bit.

Checklist

Fixed issues

Tests #15532
Tests #15522
Tests #15552

@maxkatz6 maxkatz6 added enhancement os-windows backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 30, 2024
@maxkatz6 maxkatz6 force-pushed the integration-tests-updates branch 2 times, most recently from 5c43f68 to 8033719 Compare April 30, 2024 07:14
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047904-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047916-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047938-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 force-pushed the integration-tests-updates branch from 01fbe57 to 14e8376 Compare May 1, 2024 01:24
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047960-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047964-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 requested a review from grokys May 1, 2024 08:02
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047970-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@robloo
Copy link
Contributor

robloo commented May 3, 2024

This is great! Thanks for taking the time to add these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokys grokys Awaiting requested review from grokys

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch enhancement os-macos os-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxkatz6 @avaloniaui-bot @robloo