Invalidate brush when transform changed event is fired #15098
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
kekekeks
requested changes
Mar 24, 2024
| oldMutableValue.Changed -= OnTransformChanged; | ||
|
|
||
| if (newValue is IMutableTransform newMutableValue) | ||
| newMutableValue.Changed += OnTransformChanged; | ||
| _resource.ProcessPropertyChangeNotification(change); |
There was a problem hiding this comment.
This method is supposed to properly handle the change notification including nested resource changes, so the fix is incorrect and will cause memory leaks if transform is reused
There was a problem hiding this comment.
Is there a client method to notify server if the resources change and need to be reserialized? Or is it a completely wrong approach?
There was a problem hiding this comment.
Transform itself is supposed to notify the server about its changes. The bug is most likely on the server-side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Brushes will be invalidated when their bound Transforms fire a Changed event.
What is the current behavior?
Brushes are not invalidated when their bound Transform is changed (not the property, but the inner matrix).
What is the updated/expected behavior with this PR?
Changes to bound transform will cause the brush to invalidate and redraw.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
n/a
Obsoletions / Deprecations
n/a
Fixed issues
Fixes #15097