Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple ToDoList-App #76

Merged
merged 9 commits into from
May 21, 2024
Merged

Simple ToDoList-App #76

merged 9 commits into from
May 21, 2024

Conversation

timunie
Copy link
Collaborator

@timunie timunie commented Feb 2, 2024

What does the pull request do?

Scope of this PR:

  • fix or update to an existing sample
  • add a new sample

Spoiler:
image

What is the current behavior?

The TodoList tutorial is kinda outdated and needs some updates and simplifications for beginners

Checklist

If this is a new Sample

In any case

  • Spell-checking done
  • Checked if all hyperlinks work
  • Checked if all images are visible

Fixed issues

@timunie timunie marked this pull request as ready for review April 28, 2024 19:27
Copy link
Contributor

@stevemonaco stevemonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to read+follow the README yet, but the rest LGTM overall.

/* NOTE:
*
* Please mind that this samples uses the CommunityToolkit.Mvvm package for the ViewModels. Feel free to use any other
* MVVM-Framework (like ReactiveUI or Prsim) that suits your needs best.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo. Prsim -> Prism.

@timunie
Copy link
Collaborator Author

timunie commented May 21, 2024

yolo merging. If there are some typos left, that can be fixed in new PRs. Otherwise I got some really positive reviews already from newbies.

@timunie timunie merged commit db98233 into AvaloniaUI:main May 21, 2024
1 check passed
@timunie timunie deleted the feat/ToDoListApp branch May 21, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants