-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple ToDoList-App #76
Conversation
src/Avalonia.Samples/CompleteApps/SimpleToDoList/Views/MainWindow.axaml
Outdated
Show resolved
Hide resolved
src/Avalonia.Samples/CompleteApps/SimpleToDoList/Models/ToDoItem.cs
Outdated
Show resolved
Hide resolved
4e2174e
to
797ffdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a chance to read+follow the README yet, but the rest LGTM overall.
src/Avalonia.Samples/CompleteApps/SimpleToDoList/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
/* NOTE: | ||
* | ||
* Please mind that this samples uses the CommunityToolkit.Mvvm package for the ViewModels. Feel free to use any other | ||
* MVVM-Framework (like ReactiveUI or Prsim) that suits your needs best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo. Prsim -> Prism.
src/Avalonia.Samples/CompleteApps/SimpleToDoList/Views/MainWindow.axaml
Outdated
Show resolved
Hide resolved
This sample will not cover Dialogs nor DataPersistence. That should be done in a more complex App following later
yolo merging. If there are some typos left, that can be fixed in new PRs. Otherwise I got some really positive reviews already from newbies. |
What does the pull request do?
Scope of this PR:
Spoiler:
What is the current behavior?
The TodoList tutorial is kinda outdated and needs some updates and simplifications for beginners
Checklist
If this is a new Sample
In any case
Fixed issues