Check the plan on launch site to show domain message or not

[JuanLucha]

Related to https://github.com/Automattic/dotcom-forge/issues/7164

Proposed Changes

We need to check the site's current plan when it launches. If the site doesn't include a plan, like when the site was created by A4A, it shouldn't show the "claim your domain" message. This PR makes this change.

Why are these changes being made?

We don't offer a free domain as part of a Creator plan made by A4A. More context: https://github.com/Automattic/automattic-for-agencies-dev/issues/482

Testing Instructions

Instructions to test not A4A sites

• Go to http://calypso.localhost:3000/sites and create a site normally. It would be awesome to test different plans, including Free.
• In My Home, click on "Launch your site" (note: there are different launchpads, so the link to launch your site could be in a different order):

You should see different popups depending on the circumstances of the blog:

• a free blog (no domain included):

• a paid plan, including a domain:

Instructions to test A4A sites

• Log into our A4A testing account (details here: pfunGA-1mD-p2).
• Create a new site (or use one of the existing sites that hasn't launched yet).
• Create a new admin user on that site. You will require the credentials of such user in your local calypso. Accept the invitation in the new admin user email.
• Login to the site using your local Calypso instance and this newly created account.
• In My Home, click on "Launch your site":
• This site has a paid plan, created with A4A (no domain included), so the popup should look like this:

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108589

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108589&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108589&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~1 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +54 B  (+0.0%)       +1 B  (+0.0%)
entry-main           +54 B  (+0.0%)       +1 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4361 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
home                                  +66906 B  (+4.2%)   +16722 B  (+3.7%)
site-purchases                           +62 B  (+0.0%)      +21 B  (+0.0%)
purchases                                +62 B  (+0.0%)      +21 B  (+0.0%)
plans                                    +62 B  (+0.0%)      +19 B  (+0.0%)
jetpack-connect                          +62 B  (+0.0%)      +19 B  (+0.0%)
jetpack-cloud-pricing                    +62 B  (+0.0%)      +19 B  (+0.0%)
jetpack-cloud-features-comparison        +62 B  (+0.0%)      +19 B  (+0.0%)
email                                    +62 B  (+0.0%)      +21 B  (+0.0%)
domains                                  +62 B  (+0.0%)      +21 B  (+0.0%)
checkout                                 +62 B  (+0.0%)      +19 B  (+0.0%)
stats                                    -13 B  (-0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~19 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             +62 B  (+0.0%)      +19 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal        +62 B  (+0.0%)      +19 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[ivan-ottinger]

Nice! I haven't had a chance to fully review and test the proposed changes, but noticed couple smaller things on the initial read through the code. Please see the inline comments below. 🙂

As, I am approaching EOD, I will finish reviewing it in the morning (if nobody gets to it earlier)

[ivan-ottinger]

Sharing a couple more thoughts.

[wongasy]

Looks like there are selectors (e.g. getSitePlanSlug) that we can leverage to simplify the code.

Suggested change

	const purchases = useSelector( ( state ) => getSitePurchases( state, site?.ID ) );
	const actualPlanPurchase =
	purchases
	.filter(
	( purchase ) => purchase.productSlug === site?.plan?.product_slug && purchase.active
	)
	.sort( ( a, b ) => new Date( a.expiryDate ) - new Date( b.expiryDate ) )[ 0 ] || null;
	const isA4ASite = actualPlanPurchase?.partnerType === 'a4a_agency';
	const isLoading = useSelector( isFetchingSitePurchases );
	useEffect( () => {
	dispatch( fetchSitePurchases( site?.ID ) );
	}, [ dispatch, site?.ID ] );
	useEffect( () => {
	if ( ! isLoading && ( ! isPaidPlan || purchases.length > 0 ) && ! isInitiallyLoaded ) {
	setIsInitiallyLoaded( true );
	}
	}, [ isLoading, purchases, isPaidPlan, isInitiallyLoaded ] );
	const sitePlanSlug = useSelector( ( state ) => getSitePlanSlug( state, site?.ID ) );
	const purchases = useSelector( ( state ) => getSitePurchases( state, site?.ID ) );
	const actualPlanPurchase = purchases.filter( ( purchase ) => purchase.productSlug === sitePlanSlug );
	const isA4ASite = isA4APurchase( actualPlanPurchase[0] );

Note that in the above suggestion, I've also introduced a helper function isA4APurchase() in lib/purchases to avoid sprinkling the string literal to various parts of the code base.

export function isA4APurchase( purchase?: Purchase ) {
	return 'a4a_agency' === purchase?.partnerType;
}

[ivan-ottinger]

I like the approach of introducing isA4APurchase that can be potentially reused later. It simplifies the whole logic as well. 👌🏼

[JuanLucha]

Pretty nice, indeed 👍

[wongasy]

Instead of removing the mentions of a custom domain, we can probably updating https://github.com/Automattic/wp-calypso/pull/90866/files#diff-b2a3bdf3b4cec65b339e0803b39186ea50d15861cfa347b97294688a3b89e58eR69 to ensure we render the upsell banner for A4A sites!

[JuanLucha]

Good point 👍

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/dont-show-free-domain-launch-popup on your sandbox.