Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency in the sub-description of the plan selection component. #90857

Merged
merged 2 commits into from
May 20, 2024

Conversation

andregardi
Copy link
Contributor

@andregardi andregardi commented May 17, 2024

Proposed Changes

image
image

Plans page: Add currency in the sub-description of the plan selection component.

Testing Instructions

  • With an Entrepreneur trial site, open the plans page.
  • Check that the currency code was added to the sub-description of the price.
  • Check it for different payment periods, Pay annually , Pay every 2 years, Pay every 3 years.
  • There is no currency code on the the Pay monthly period.
  • Try different idioms. The translation should still work, because translated text is still the same.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andregardi andregardi self-assigned this May 17, 2024
@andregardi andregardi requested a review from a team May 17, 2024 18:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 17, 2024
@matticbot
Copy link
Contributor

matticbot commented May 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~28 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
plans       +162 B  (+0.0%)      +28 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/currencycode-plan-price-text on your sandbox.

Copy link
Contributor

@phcp phcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as expected. Nice work!

@andregardi andregardi force-pushed the update/currencycode-plan-price-text branch from 2f3caed to 02f5f2a Compare May 20, 2024 15:50
@andregardi andregardi merged commit 9b77d29 into trunk May 20, 2024
11 checks passed
@andregardi andregardi deleted the update/currencycode-plan-price-text branch May 20, 2024 16:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants