Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav redesign - update github deployments header style #90856

Merged
merged 4 commits into from
May 21, 2024

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented May 17, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7188

Proposed Changes

  • Updates header-cake component to support using alternative icon (i.e. chevron-left)
  • Updates github deployment preview pane header to reflect design changes

Before

Screenshot 2024-05-17 at 19 15 45

After

Screenshot 2024-05-17 at 19 15 53

Not sure about

  • The back icon size is 18px - will need to amend the HeaderCakeBack component to support alternative sizes.
  • The back link onClick event just redirects to /sites - I don't appear to have access to the closeSitePreviewPane function which I think would be cleaner here.

Testing Instructions

  • Go to Github deployments preview pane for a test site and confirm styles are ok

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented May 17, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/github-deployments-header on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented May 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~147 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
github-deployments                     +64 B  (+0.0%)      +27 B  (+0.0%)
videopress-flow                        +18 B  (+0.0%)       +8 B  (+0.0%)
update-design-flow                     +18 B  (+0.0%)       +8 B  (+0.0%)
themes                                 +18 B  (+0.0%)       +7 B  (+0.0%)
theme                                  +18 B  (+0.0%)       +5 B  (+0.0%)
site-purchases                         +18 B  (+0.0%)       +7 B  (+0.0%)
settings                               +18 B  (+0.0%)       +6 B  (+0.0%)
sensei-flow                            +18 B  (+0.0%)       +8 B  (+0.0%)
security                               +18 B  (+0.0%)      +10 B  (+0.0%)
purchases                              +18 B  (+0.0%)       +7 B  (+0.0%)
podcasts-flow                          +18 B  (+0.0%)       +8 B  (+0.0%)
plugins                                +18 B  (+0.0%)       +7 B  (+0.0%)
people                                 +18 B  (+0.0%)       +6 B  (+0.0%)
migrate                                +18 B  (+0.0%)       +7 B  (+0.0%)
media                                  +18 B  (+0.0%)      +11 B  (+0.0%)
link-in-bio-tld-flow                   +18 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-plugin-management        +18 B  (+0.0%)       +7 B  (+0.0%)
import-hosted-site-flow                +18 B  (+0.0%)       +7 B  (+0.0%)
import-flow                            +18 B  (+0.0%)       +7 B  (+0.0%)
hosting                                +18 B  (+0.0%)       +7 B  (+0.0%)
help                                   +18 B  (+0.0%)       +6 B  (+0.0%)
google-my-business                     +18 B  (+0.0%)       +8 B  (+0.0%)
email                                  +18 B  (+0.0%)       +5 B  (+0.0%)
domains                                +18 B  (+0.0%)       +8 B  (+0.0%)
devdocs                                +18 B  (+0.0%)      +11 B  (+0.0%)
copy-site-flow                         +18 B  (+0.0%)       +8 B  (+0.0%)
concierge                              +18 B  (+0.0%)       +9 B  (+0.0%)
comments                               +18 B  (+0.0%)       +6 B  (+0.0%)
account-close                          +18 B  (+0.0%)       +7 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~57 bytes added 📈 [gzipped])

name                                               parsed_size           gzip_size
async-load-store-app-store-stats-listview                +18 B  (+0.0%)       +9 B  (+0.0%)
async-load-signup-steps-domains                          +18 B  (+0.0%)       +8 B  (+0.0%)
async-load-calypso-reader-tag-stream-main                +18 B  (+0.1%)       +5 B  (+0.1%)
async-load-calypso-reader-site-stream                    +18 B  (+0.1%)       +9 B  (+0.1%)
async-load-calypso-reader-search-stream                  +18 B  (+0.0%)       +8 B  (+0.0%)
async-load-calypso-reader-feed-stream                    +18 B  (+0.1%)       +9 B  (+0.1%)
async-load-calypso-post-editor-media-modal               +18 B  (+0.0%)      +11 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal        +18 B  (+0.0%)      +11 B  (+0.0%)
async-load-calypso-my-sites-stats-comment-follows        +18 B  (+0.1%)       +7 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

.header-cake__back {
color: var(--studio-gray-60);
font-size: $font-body-small;
svg {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make the icon smaller and closer to the "Back" text?

Design Current
image image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simplest way I found here is to set the width in css with !important.

client/my-sites/github-deployments/deployments/styles.scss Outdated Show resolved Hide resolved
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised.

I noted though that there are a few things that could be changed, but I don't know where the Figma with the design specification is located to confirm whether it was requested this way or not. It can be polished if needed in a follow-up, but wanted to mention it just in case (cc @lucasmendes-design).

Back button not aligned with card title

Screenshot 2024-05-20 at 16 52 06

Chevron not centered

Screenshot 2024-05-20 at 16 51 18

There is a separation line that does not appear in the design shared here

Screenshot 2024-05-20 at 16 53 47

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@taipeicoder taipeicoder merged commit 774b54d into trunk May 21, 2024
11 checks passed
@taipeicoder taipeicoder deleted the update/github-deployments-header branch May 21, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants