-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav redesign - update github deployments header style #90856
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~147 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~57 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
.header-cake__back { | ||
color: var(--studio-gray-60); | ||
font-size: $font-body-small; | ||
svg { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The simplest way I found here is to set the width in css with !important
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised.
I noted though that there are a few things that could be changed, but I don't know where the Figma with the design specification is located to confirm whether it was requested this way or not. It can be polished if needed in a follow-up, but wanted to mention it just in case (cc @lucasmendes-design).
Back button not aligned with card title
Chevron not centered
There is a separation line that does not appear in the design shared here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes https://github.com/Automattic/dotcom-forge/issues/7188
Proposed Changes
chevron-left
)Before
After
Not sure about
HeaderCakeBack
component to support alternative sizes./sites
- I don't appear to have access to thecloseSitePreviewPane
function which I think would be cleaner here.Testing Instructions
Pre-merge Checklist