-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogRocket: Enable network logging #90845
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~87 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, I had some issues testing the change because I could see request events getting logged, but saw some examples from @Initsogar that had the Authorization nulled out.
Resolves https://github.com/Automattic/jetpack-backup-team/issues/485
Important
LogRocket is currently disabled in production. The purpose of this PR is to be ready for when we decide to enable it.
Proposed Changes
Why are these changes being made?
Testing Instructions
?flags=ad-tracking,logrocket
to the URL to enable the feature flags.localStorage.setItem( 'debug', 'calypso:*' );
logrocket
Backup
orSettings
page and ensure you see these debug records:Network
tab that there is API calls to LogRocket including a request payload similar to this:Pre-merge Checklist