Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor blog logic #368

Merged
merged 4 commits into from May 9, 2024
Merged

Refactor blog logic #368

merged 4 commits into from May 9, 2024

Conversation

gtg7784
Copy link
Contributor

@gtg7784 gtg7784 commented May 7, 2024

Pull Request Summary

  1. Refactor blog index page to displaying english posts when there's nothing
  2. Refactor blog/[slug] page to query english post when there's nothing on the current locale
  3. Refactor blog/[slug] page's fetch logic for better readability

Why?

Because there's nothing posted when I change locale to Korean
AS-IS
image

So, I want to displaying english posts when there's nothin on current locale
TO-BE
image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Changes

  • Refactor blog index page to displaying english posts when there's nothing
  • Refactor blog/[slug] page to query english post when there's nothing on the current locale
  • Refactor blog/[slug] page's fetch logic for better readability

Copy link

github-actions bot commented May 7, 2024

Visit the preview URL for this PR (updated for commit 7f3deb2):

https://astar-home--pr368-feat-astar-blog-a1i2w1g9.web.app

(expires Tue, 14 May 2024 12:09:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7e0886861adbcd06bf502c744bee9aac94664d7f

Copy link
Collaborator

@ayumitk ayumitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMT! Thank you

@gtg7784 gtg7784 merged commit 8867878 into main May 9, 2024
5 checks passed
@gtg7784 gtg7784 deleted the feat/astar-blog branch May 9, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants