-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add astar portal button to the header #367
Conversation
Visit the preview URL for this PR (updated for commit a519ffc): https://astar-home--pr367-feat-add-portal-butt-1suol8rg.web.app (expires Thu, 02 May 2024 00:43:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7e0886861adbcd06bf502c744bee9aac94664d7f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
btw, are you using some sorting extension or plugin for tailwindcss? some of the classes are sorted @ayumitk |
@gtg7784 Ah, sorry. I kept enabling the plugin Tailwind Raw Reorder in VScode while I edited the files. I think it might be better to use prettier plugin or something and include its config file in the repo. |
Oh, it is just a curious. That’s good! I’ll check some prettier plug-in or eslint plugin for ordering classname. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured out. The PR is already merged :) |
Pull Request Summary
Check list