Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add astar portal button to the header #367

Merged
merged 3 commits into from
Apr 25, 2024
Merged

add astar portal button to the header #367

merged 3 commits into from
Apr 25, 2024

Conversation

ayumitk
Copy link
Collaborator

@ayumitk ayumitk commented Apr 25, 2024

Pull Request Summary

Screenshot 2024-04-25 at 9 29 40 AM
  • Added the "Astar Portal" button to the header

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Apr 25, 2024

Visit the preview URL for this PR (updated for commit a519ffc):

https://astar-home--pr367-feat-add-portal-butt-1suol8rg.web.app

(expires Thu, 02 May 2024 00:43:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7e0886861adbcd06bf502c744bee9aac94664d7f

Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gtg7784
Copy link
Member

gtg7784 commented Apr 25, 2024

btw, are you using some sorting extension or plugin for tailwindcss? some of the classes are sorted @ayumitk

@ayumitk
Copy link
Collaborator Author

ayumitk commented Apr 25, 2024

@gtg7784 Ah, sorry. I kept enabling the plugin Tailwind Raw Reorder in VScode while I edited the files. I think it might be better to use prettier plugin or something and include its config file in the repo.

@gtg7784
Copy link
Member

gtg7784 commented Apr 25, 2024

@gtg7784 Ah, sorry. I kept enabling the plugin Tailwind Raw Reorder in VScode while I edited the files. I think it might be better to use prettier plugin or something and include its config file in the repo.

Oh, it is just a curious. That’s good! I’ll check some prettier plug-in or eslint plugin for ordering classname.

@ayumitk ayumitk merged commit b7e13b0 into main Apr 25, 2024
4 checks passed
@ayumitk ayumitk deleted the feat/add-portal-button branch April 25, 2024 04:51
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but for some reason I don't have an option to approve the PR
image

@bobo-k2
Copy link
Contributor

bobo-k2 commented Apr 25, 2024

I figured out. The PR is already merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants