feat: remove mention of fixed xcm weights #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit ebc4362): https://astar-docs--pr662-feat-update-xcm-weig-exph36n7.web.app (expires Fri, 03 May 2024 15:18:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d |
meganskye
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent runtime upgrades we moved from fixed weights for XCM instructions to individual benchmarked weights.
This PR removed the mention of fixed weight for XCM from the docs to make sure not to mislead the used/dev. Also there is no good way to estimate the XCM weights for destination chain now that most of parachains and relays have adopted xmc benchmarks, only reliable way now is to check the xcm weights manaully for each destination chain.
Ref: AstarNetwork/Astar#1206