Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-create hotfix branch after deployment #1282

Merged
merged 4 commits into from May 13, 2024
Merged

Re-create hotfix branch after deployment #1282

merged 4 commits into from May 13, 2024

Conversation

gtg7784
Copy link
Contributor

@gtg7784 gtg7784 commented May 8, 2024 •
edited

Pull Request Summary

Sorry for the long commit message, It is for the create hotfix branch after Production deployment automatically

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Changes

  • Add few steps after production deployment in s3-production.yml github action

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited

Visit the preview URL for this PR (updated for commit 331c06c):

https://astar-apps--pr1282-create-hotfix-after-xua3o3v0.web.app

(expires Thu, 16 May 2024 13:43:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@gtg7784 gtg7784 changed the title Create hotfix branch after deployment with github action Re-create hotfix branch after deployment May 8, 2024
bobo-k2
bobo-k2 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtg7784
Copy link
Contributor Author

gtg7784 commented May 9, 2024

seperate remove & re-create for error handling

this is for the prevent this actions goes fail when release-hotfix is not exist

@gtg7784 gtg7784 merged commit ab44a93 into main May 13, 2024
9 checks passed
@gtg7784 gtg7784 deleted the create-hotfix-after-prod-deployment branch May 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@impelcrypto impelcrypto impelcrypto approved these changes

@codespool codespool Awaiting requested review from codespool

@ehsanhajian ehsanhajian Awaiting requested review from ehsanhajian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gtg7784 @bobo-k2 @impelcrypto