Estimated realized inflation #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a311277): https://astar-apps--pr1280-feat-realized-inflat-72fnz0sv.web.app (expires Tue, 21 May 2024 11:15:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
impelcrypto
reviewed
May 13, 2024
src/hooks/useInflation.ts
Outdated
| [$api], | ||
| async () => { | ||
| estimatedInflation.value = await estimateRealizedInflation(); | ||
| console.log('Realized inflation:', estimatedInflation.value); |
There was a problem hiding this comment.
Let's use console.info if you want to show this in the console
There was a problem hiding this comment.
Actually, this is not needed. Removed in e120bdb
gtg7784
requested changes
May 14, 2024
impelcrypto
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Estimated realized inflation calculation (ref). The calculation calculates slope from first block of the current cycle till the current block and assumes the same slope until the end of the period. This estimation introduces an error which will decrease after stakers clam their rewards (after first build and earn subperiod) and decrease even more as we are approaching the end of the current cycle.
We have beens struggling how to display inflation with just one meaningful number and seems this is the best way so far. In the next iteration we plan to add inflation chart as defined in the document referenced above.
Check list