feat: added layerzero bridge #1267
Open
+7,131
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2356fe0): https://astar-apps--pr1267-feat-lz-bridge-e8jiq6to.web.app (expires Thu, 16 May 2024 17:25:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
… into feat/lz-bridge
impelcrypto
requested review from
bobo-k2,
codespool,
gtg7784,
ayumitk and
Kahonnohak
bobo-k2
approved these changes
May 9, 2024
| const abiCoder = new ethers.utils.AbiCoder(); | ||
| const byte32Address = abiCoder.encode(['address'], [address]); | ||
|
|
||
| if (byte32Address.length !== 66) { |
There was a problem hiding this comment.
Please create a constant with descriptive name
| @@ -68,7 +68,8 @@ export default { | |||
| blankDestAddress: 'Destination address is blank', | |||
| inputtedInvalidAddress: 'Inputted invalid address', | |||
| selectedInvalidNetworkInWallet: 'Selected invalid network in your wallet', | |||
| balanceNotEnough: 'You do not have enough ETH in your account to pay for the transaction fee', | |||
| balanceNotEnough: | |||
There was a problem hiding this comment.
This key is already defined under warning. Also, we have a similar message in error.invalidBalance. Please reuse.
bobo-k2
reviewed
May 9, 2024
src/i18n/en-US/index.ts
Outdated
| @@ -1035,8 +1036,12 @@ export default { | |||
| text: '3rd Party Bridge. Fast and reliable crypto transfers across networks to Astar zkEVM.', | |||
| }, | |||
| warning32blocks: 'It could take around 10~20mins or more to finalize', | |||
| warningLzWithdrawal: | |||
| 'It could take more than 7 days to finalize the bridge transaction from Astar zkEVM to Astar EVM due to block confirmation fixed by LayerZero', | |||
There was a problem hiding this comment.
Time to bridge is reduced to 6 hours
There was a problem hiding this comment.
Fixed, btw, I'm still waiting for DOT to reduce to 6 hours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Check list
This pull request makes the following changes:
Adds
