Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional leaderboards for voting subperiod #1188

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Feb 14, 2024

Pull Request Summary

Added transactions and users leaderboards for voting subperiod

image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

bobo-k2 and others added 7 commits January 30, 2024 12:51
* add text ellipsis to the dapp card

* update

* Revert "update"

This reverts commit 29c7d3f.

* fix the arrow style of the ads section

* fix builders card layout

* fix dapp page short description
* Don't batch a single call

* Ubstoppable grants background

* Min staking amount warning condition fix

* Code review update

* Category title padding fix
@bobo-k2 bobo-k2 changed the base branch from main to release-hotfix February 14, 2024 09:30
Copy link

github-actions bot commented Feb 14, 2024

Visit the preview URL for this PR (updated for commit b86f7d1):

https://astar-apps--pr1188-feat-staking-v3-lead-i6eti30s.web.app

(expires Thu, 22 Feb 2024 08:22:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@Kahonnohak
Copy link
Contributor

Hi @bobo-k2 Thank you! wanted to approve straight away to reduce workload but... please check

  • Can those three fit width width until the certein width (Tier leaderboard size)?
  • Can the hight be alined? So the right two only has one line but using the same height when there's 2 line one
  • For the ranking, the icon size is not right please take a look
Screenshot 2024-02-14 at 10 33 02

@@ -98,13 +100,22 @@ export function useDapps() {
return dapps.find((d) => d.owner === ownerAddress && d.state === DappState.Registered);
};

const fetchDappStats = async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const fetchDappStats = async () => {
const fetchDappStats = async (): Promise<void> => {

Base automatically changed from release-hotfix to main February 16, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants