Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MetaMask Snap install page #1048

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: MetaMask Snap install page #1048

wants to merge 10 commits into from

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Nov 23, 2023

Pull Request Summary

  • Fixes a misspelling initiatePolkdatodSnap --> initiatePolkadotSnap and some styling lint
  • Adds a new page to install the MetaMask Astar Snap
  • Start testing here: http://localhost:8080/snap

image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Nov 23, 2023

Visit the preview URL for this PR (updated for commit e14331f):

https://astar-apps--pr1048-feat-snap-home-page-mc6ar8pv.web.app

(expires Thu, 07 Dec 2023 18:25:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@gluneau gluneau marked this pull request as ready for review November 28, 2023 20:07
@Kahonnohak
Copy link
Contributor

Thanks Greg

Is it your purpose to remove sidebar contents as well as header contents???

@gluneau
Copy link
Contributor Author

gluneau commented Nov 29, 2023

Yes, because it would not even work before they complete the steps.
Less to click, more chances they follow the flow.

@Kahonnohak
Copy link
Contributor

Please make some changes

You cannot remove the side bar that really looks weird (you cannot remove index from index). Please bring the side bar back.

  • If users then press the button on the sidebar they should go back to the net work they were connected before
  • If users don't have cache then give the wallet modal up when they connected to the asset page

please also change the wallet modal behaviour

  • If user doesn't have Snap yet, bring the users to this page
  • If user does have the Snap, that will connect

@Kahonnohak
Copy link
Contributor

Hi @gluneau sorry but we have no one who can work on this, so lets then release with docs information and we can maybe come back next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants