Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated dApps improvement #1153

Merged
merged 2 commits into from Jan 25, 2024
Merged

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Jan 23, 2024

Summary

To provide more capacity for new dApps, when dApp is unregistered, it will be removed from IntegratedDApps storage.
The dApp Id will still remain occupied, but that can be resolved in the future when required.

Overview

  • NotOperatedDApp error has been removed and completely replaced with ContractNotFound error
  • DAppInfo struct has been changed, with field state being removed
  • Removed executed migrations

@Dinonard Dinonard added the runtime This PR/Issue is related to the topic “runtime”. label Jan 24, 2024
@Dinonard Dinonard self-assigned this Jan 24, 2024
@Dinonard Dinonard added the shibuya related to shibuya label Jan 24, 2024
@Dinonard Dinonard marked this pull request as ready for review January 24, 2024 08:11
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/collator-selection/src 90% 0%
pallets/dapp-staking-v3/src 88% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dapps-staking/src 90% 0%
precompiles/dapps-staking/src 94% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/static-price-provider/src 58% 0%
primitives/src/xcm 66% 0%
pallets/dapps-staking/src/pallet 86% 0%
pallets/unified-accounts/src 84% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
primitives/src 59% 0%
pallets/inflation/src 86% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dapp-staking-migration/src 49% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
chain-extensions/xvm/src 0% 0%
pallets/ethereum-checked/src 75% 0%
pallets/astar-xcm-benchmarks/src 89% 0%
precompiles/dapp-staking-v3/src 90% 0%
chain-extensions/types/assets/src 0% 0%
pallets/xc-asset-config/src 64% 0%
precompiles/sr25519/src 64% 0%
precompiles/xvm/src 74% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/block-rewards-hybrid/src 91% 0%
precompiles/xcm/src 72% 0%
precompiles/assets-erc20/src 81% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/xvm/src 51% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
Summary 79% (4361 / 5526) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit f9391d3 into master Jan 25, 2024
14 of 15 checks passed
@Dinonard Dinonard deleted the feat/dsv3-registered-dapp-counter branch January 25, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants