Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Mount: Siyi, SToRM32_serial and ViewPro drivers always use 1st gimbal serial device #27090

Open
rmackay9 opened this issue May 18, 2024 · 0 comments

Comments

@rmackay9
Copy link
Contributor

As discovered during this documentation update, the Siyi, SToRM32 and ViewPro drivers always try to use the first serial port that is set to Gimbal (e.g. SERIALx_PROTOCOL = 8). This means that if two serial gimbals are setup both will try and use the same serial port.

As a minimum we should change the call to the SerialManager to use the serial instance. This is sufficient for users only using serial gimbals.

This fix isn't a sufficient fix for the case where the 1st gimbal is not a serial gimbal (e.g. a PWM servo gimbal) because the 2nd gimbal (a serial gimbal) would try and use the 2nd serial port (e.g. the 2nd case of SERIALx_PROTOCOL = 8) when really it should use the first. To fix this we need to modify the serial gimbal consturctor to take in a serial instance argument similar to what we do for rangefinder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant