Fix 834 and Add Unit Tests (dependent on #780) #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a static library of all apmplanner classes except of main, moved qgroundcontrol.pro to apmplanner_core.pro to keep the build process the same as before
removed old project configuration and source files from qgcunittest.pro because that is now part of the new common apmplanner-core library added a test for the qt test framwork to make sure the new setup works as expected
versions, copied from ApmFirmwareConfig.cc added unit tests for version comparator
in ApmFirmwareConfig.cc This bug was already fixed in AutoUpdateCheck.cc commit 8de0f15
… defined in the regex, therefore it is always 2 and the if statement is useless
…rsion string in one place fixed uninitialized variable warning
…s per group, allow muliple digits in build number
Conflicts: qgroundcontrol.pro
whenever a waypoint is dragged, go through the list of waypoints and find all other selected waypoints - shift these waypoints by the same lat/long difference as the initial waypoint was moved
…locking SpinBox signals
… SpinBox in one list to fix duplicate for loop
Conflicts: qgroundcontrol.pro
… (issue #40) Verbose flag is always true and debug flag always false - therefore removed these flags, if another verbosity level is needed the logging system should be used
…:Type and comparison between enum QVariant::Type and enum QMetaType::Type according to Qt documentation QVariant::type() should be interpreted as QMetaType::Type
… has non-virtual destructor (issue #40)
Mark unused parameters as unused
Mark parameters as not used
Completely remove functions that are empty or not used
This reverts commit 5f0890a.
|
Thanks for finding a solution. I can't merge this commit until the fix is against current master. I know I need to pull in the other two PRs you have, but this PR is essentially everything is an 'omnibus' PR. I can cherry-pick dc60229, but it much easier to merger PRs against the current master without the 'noise' of other PRs |
|
Sorry for that, but I wanted to cover my changes with a unit test, that's why I used my master branch. |
|
No worries. I'll look at the unit test you added again, the problem was I had some OSX build issue, and I hadn't had time to resolve (I'll try and find some time to fix that as it's a good PR) |
|
cherry-picked fix with 6f4ec1f That still leaves the unit test case pr and then the two test cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a unit test that reproduces the segfault, no matter if filte1.4, or flite2.0 is installed on my Ubuntu 14.04
The unit test works fine for flite1.4 and flite2.0, if commit 5f0890a is reverted