Fix potential github action smells #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use 'if' for upload-artifact action - Avoid uploading artifacts on forks - Prevent running issue/PR actions on forks - Avoid deploying jobs on forks
|
@martincostello is it really neccessary to run |
|
I didn't specifically disable it because my understanding was that GitHub automatically disables actions for new forks. This was something I used to do in all my own repos, but I've stopped because I thought the default didn't need it anymore. See https://github.com/orgs/community/discussions/26704#discussioncomment-3252979 If that isn't the case we can look to turn it off explicitly, but if we do so I would want to code to do it the way I suggested in my review, not with hard-coding the repository name: #2097 (comment) |
Co-authored-by: Martin Costello <martin@martincostello.com>
Restore whitespace.
Disable three additional workflows on forks.
martincostello
added
enhancement
CI/build
github_actions
martincostello
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Hey! 馃檪
I want to contribute the following changes to your workflow:
(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)
The issue or feature being addressed
Details on the issue fix or feature implementation
Confirm the following