Easier access to adding custom buttons to existing vanilla menu categories. #9835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't need to wait for `build` to be able to modify
MEEPofFaith
commented
May 11, 2024
| @@ -28,6 +28,30 @@ public class MenuFragment{ | |||
| private Button currentMenu; | |||
| private MenuRenderer renderer; | |||
| private Seq<MenuButton> customButtons = new Seq<>(); | |||
| public MenuButton[] desktopButtons; | |||
There was a problem hiding this comment.
Should this be final?
There was a problem hiding this comment.
...the line thats highlighted by this comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop
MenuButtons are now only initialized once and saved todesktopButtonsandsubmenuis now aSeq, making it possible to add to easily add to vanilla submenus without this pain.If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: