Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules dialog changes #9792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ApsZoldat
Copy link
Contributor

  1. New banned blocks/units dialog (other people asked me to PR this from my mod, so... i think no one will argue?)
  2. Rule info buttons are now displayed again on mobile devices
  3. Other elements in rules dialog like number() and numberi() now try to display rule info too. There's only checks that have info texts in vanilla right now, but this change is useful for mods

Info buttons (Vars.mobile = true):

1

New dialog (with somewhat responsive behavior):

2
3
P.S: this dialog can be opened in portrait mode when editing rules in MapPlayDialog

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

Copy link
Contributor

@BlueTheCube BlueTheCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly one of the quality of life features

@S0meM
Copy link

S0meM commented Apr 29, 2024

What is your mod?

@ApsZoldat
Copy link
Contributor Author

ApsZoldat commented Apr 29, 2024

This dialog is a slightly changed version of Mapping Utilities' (new version) ban dialog https://github.com/ApsZoldat/MindustryMappingUtilities

The mod itself is not my proudest... thing to be honest
But this dialog should be ok, at least you can now add multiple items without content table just disappearing (instead of rebuilding)

@BlueTheCube
Copy link
Contributor

BlueTheCube commented May 10, 2024

if it ain't merged, put it back in your mod to wait

@ApsZoldat
Copy link
Contributor Author

New dialog is ported FROM my mod, what do you mean? If you're about the info buttons, well, it's just... not a big deal, huh?

@BlueTheCube
Copy link
Contributor

what about the planets filter in the banned blocks dialog?

@ApsZoldat
Copy link
Contributor Author

It doesn't work well with units, because there's no actual way to get unit type's planet except checking its production cost IIRC (which just doesn't work in all cases and is a shenanigan)

Maybe it's TODO for me, but more like shelved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants