New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rules dialog changes #9792
base: master
Are you sure you want to change the base?
Rules dialog changes #9792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truly one of the quality of life features
What is your mod? |
This dialog is a slightly changed version of Mapping Utilities' (new version) ban dialog https://github.com/ApsZoldat/MindustryMappingUtilities The mod itself is not my proudest... thing to be honest |
if it ain't merged, put it back in your mod to wait |
New dialog is ported FROM my mod, what do you mean? If you're about the info buttons, well, it's just... not a big deal, huh? |
what about the planets filter in the banned blocks dialog? |
It doesn't work well with units, because there's no actual way to get unit type's planet except checking its production cost IIRC (which just doesn't work in all cases and is a shenanigan) Maybe it's TODO for me, but more like shelved |
number()
andnumberi()
now try to display rule info too. There's only checks that have info texts in vanilla right now, but this change is useful for modsInfo buttons (
Vars.mobile = true
):New dialog (with somewhat responsive behavior):
P.S: this dialog can be opened in portrait mode when editing rules in
MapPlayDialog
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: