Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmet Dependencies Dialog + Auto-Import Dependencies #9752

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

MEEPofFaith
Copy link
Contributor

@MEEPofFaith MEEPofFaith commented Apr 16, 2024

Anuken/Mindustry-Suggestions#4944

auto.imports.mp4

Auto-importing actually works.

There's probably a much better way to implement this, but this is what I came up with.


If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.
    • Dialog displays properly
    • Auto-import
    • Don't check disabled mods

@MEEPofFaith MEEPofFaith changed the title Unmet Dependencies Dialog + Auto-Import Dependencies Unmet Dependencies Dialog + Auto-Import Dependencies (https://github.com/Anuken/Mindustry-Suggestions/issues/4944) Apr 17, 2024
@MEEPofFaith MEEPofFaith changed the title Unmet Dependencies Dialog + Auto-Import Dependencies (https://github.com/Anuken/Mindustry-Suggestions/issues/4944) Unmet Dependencies Dialog + Auto-Import Dependencies Apr 17, 2024
@MEEPofFaith
Copy link
Contributor Author

MEEPofFaith commented Apr 18, 2024

Hm how do I delay the import status dialog so that it appears after downloading completes.
Nevermind

@MEEPofFaith
Copy link
Contributor Author

MEEPofFaith commented Apr 18, 2024

Should be ready for merge unless some major issue is found.

@BlueTheCube
Copy link
Contributor

Anuke, will it be merged to vanilla Mindustry?

@MEEPofFaith
Copy link
Contributor Author

Soft dependency handling.

20240503-161010-javaw.mp4
20240503-161111-javaw.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants