Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow markers to be used as light sources #9733

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Redstonneur1256
Copy link
Contributor

@Redstonneur1256 Redstonneur1256 commented Apr 12, 2024

Allows for markers to be drawn as light sources using setmarker light <id> <true/false>, point markers act as point lights, I'm not sure if this should be a dedicated marker or kept as is.

image

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

Copy link
Contributor

@BlueTheCube BlueTheCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Make Marker?

@Anuken
Copy link
Owner

Anuken commented Apr 24, 2024

I think this should be a different marker. Points having two "modes" is very strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants