Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Power Gen Stat Display #9633

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

MEEPofFaith
Copy link
Contributor

@MEEPofFaith MEEPofFaith commented Mar 10, 2024

javaw_1xDiCiu0Ol

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.
    • TODO: Un-lonely the 6 water/sec
    • TODO: Test functionality of simultaneously having both item and liquid efficiency modifiers
    • TODO: Liquid display does not include consumption rate

@MEEPofFaith
Copy link
Contributor Author

javaw_cofjdUMVwR

@MEEPofFaith MEEPofFaith marked this pull request as ready for review March 15, 2024 16:33
@Anuken
Copy link
Owner

Anuken commented Mar 16, 2024

Isn't it more fun if it's a surprise?

@MEEPofFaith
Copy link
Contributor Author

Isn't it more fun if it's a surprise?

My thoughts exactly, which is why I didn't originally add it in the first place

@MEEPofFaith
Copy link
Contributor Author

Still need to figure out how to deal with the lonely 6 water/sec

@MEEPofFaith
Copy link
Contributor Author

Well I tried switching around the order they are added in steam gen, it looks even worse if the liquid consume is added after the item consume.
image

@MEEPofFaith MEEPofFaith marked this pull request as draft March 16, 2024 21:36
@MEEPofFaith
Copy link
Contributor Author

MEEPofFaith commented Mar 16, 2024

At least filtered liquids looks good.
test-mod.zip

image

@MEEPofFaith
Copy link
Contributor Author

MEEPofFaith commented Mar 16, 2024

Might as well apply my nicer looking liquid display to everywhere else.
image

@MEEPofFaith MEEPofFaith marked this pull request as ready for review March 20, 2024 01:17
@MEEPofFaith
Copy link
Contributor Author

It legitimately impossible to get the liquid input to obey the order to left().

@MEEPofFaith
Copy link
Contributor Author

javaw_jsaaXku4sc javaw_Se83Zq2BSQ

Temperature, heat capacity, viscosity, and explosiveness
@BlueTheCube
Copy link
Contributor

when merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants