Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCH] change settings for MUON_SYNC_RECO #13139

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

pillot
Copy link
Collaborator

@pillot pillot commented May 14, 2024

  • keep default time offset correction in sync mode
  • limit on max track candidates already set appropriately for pp and PbPb through MCH_CONFIG_KEY
  • change tracking parameters to cope for possible misalignment only for pp or cosmics. Keep default values for PbPb to avoid large combinatorics. I see no particular reason not to use the defaults for synthetic.

@aferrero2707 , does it look ok for you?

@pillot pillot requested a review from a team as a code owner May 14, 2024 17:43
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted
async-2023-pp-apass4
async-2023-pp-apass4-accepted
async-2024-pp-apass1
async-2024-pp-apass1-accepted
async-2022-pp-apass7
async-2022-pp-apass7-accepted
async-2024-pp-cpass0
async-2024-pp-cpass0-accepted

@aferrero2707
Copy link
Collaborator

@pillot looks good to me, sorry for the delay!

@pillot
Copy link
Collaborator Author

pillot commented May 22, 2024

Hi @shahor02 , this PR is validated from the MUON side (thanks Andrea). If this is OK for you too, can you force-merge it please (as for others, the test failures are due to git fetch issues)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants