Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHS: fix segfault when reading TRU flags in AltroDecoder.cxx #13137

Merged
merged 1 commit into from
May 21, 2024

Conversation

sevdokim
Copy link
Contributor

Hi! This is fix for seg fault when reading TRU flags in AltroDecoder.cxx

#1  o2::phos::AltroDecoder::readTRUFlags (this=0x5f99a00, hwAddress=2162, payloadSize=562) at /local/workspace/DailyBuilds/WeeklyO2Release/daily-tags.twINNhnLlC/SOURCES/O2/epn-20240419/epn-20240419/Detectors/PHOS/reconstruction/src/AltroDecoder.cxx:348

Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted
async-2023-pp-apass4
async-2023-pp-apass4-accepted
async-2024-pp-apass1
async-2024-pp-apass1-accepted
async-2022-pp-apass7
async-2022-pp-apass7-accepted
async-2024-pp-cpass0
async-2024-pp-cpass0-accepted

@sevdokim
Copy link
Contributor Author

@peressounko can you please have a look?

@sevdokim sevdokim force-pushed the phs-fix-altrodecoder-segfault branch from 9255350 to 25058c4 Compare May 14, 2024 08:38
@sevdokim
Copy link
Contributor Author

Hi @shahor02 can you please look at this PR? Seems that some checks failed due to unrelated reasons. Thanks!

@shahor02 shahor02 merged commit 189812f into AliceO2Group:dev May 21, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants