-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOD: Add TPC time0 option B #13131
AOD: Add TPC time0 option B #13131
Conversation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Subject: Compatibility Concerns with Track t0 Storage Requirements Hi @f3sch, I reviewed your presentation on the agenda, and I have some questions regarding compatibility with the t0 storage requirements for tracks (similar to my previous trackQA implementation). Based on my review, it seems there might be some discrepancies between the proposed solution and the following requirements: t0 Storage Requirements:
Would you be available to discuss these requirements in more detail and explore potential compatibility issues with your proposed solution? Marian |
Building on My Previous Comment: t0 Storage for All Tracks Availability of Delta Time: Further Discussion: |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@miranov25 This implementation is for a different use case. The question to you is: does it work also for you? |
Error while checking build/O2/fullCI for 847bb09 at 2024-05-16 06:32:
Full log here. |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Hi @jgrosseo, @pzhristov, and @f3sch, To address the challenges posed by the high-occupancy environment, I propose storing the complete TrackQA table (including track Time0) in the non-sampled regime. This dataset will be essential for post-correction processes designed to rectify induced imperfections. As discussed with Felix, this approach will simultaneously accommodate his requirements as well. To advance this request, I am currently engaging with relevant stakeholders and compiling supporting documentation for approval. I introduced a preliminary version of this proposal at yesterday’s TPC meeting. I plan to further elaborate on these plans at today’s AOT meeting and have requested a time slot with Peter on Monday for a more detailed discussion.
Best regards, Marian |
* AOD: Add TPC time0 option B Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> * AOD: skip call to truncateFloat if tpc-only track Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> * AOD: store t0 wrt to BC of assoc. collision Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> * AOD: Also store used bcOfTimeRef Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> --------- Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> (cherry picked from commit 08d9479)
As proposed today in https://indico.cern.ch/event/1416151/ this would implement option b (e.g. the inclusion of the time0 for tpc-only track with encoding of the deltaFwd/Bwd).
@miranov25 If you could please have a look in to the proposal and code to solve also your request for inclusion of t0, this would be much appreciated?